Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38704 )
Change subject: soc/intel/tigerlake: Update PMC Register Base and platform check for JSP
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38704/2/src/soc/intel/tigerlake/esp...
File src/soc/intel/tigerlake/espi.c:
https://review.coreboot.org/c/coreboot/+/38704/2/src/soc/intel/tigerlake/esp...
PS2, Line 86: 0x4d
As per the EDS, the ESPI device ID ranges from 0x4d80 to 0x4d9f, inclusive of both.
Hi Furquan,
Below CL has been pushed for Jasperlake Device ID update, please review.
https://review.coreboot.org/c/coreboot/+/38849
Can you also please reconsider the -1 on this patch ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38704
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6017a9703764b5454e7be479c1e08afe614908f1
Gerrit-Change-Number: 38704
Gerrit-PatchSet: 3
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Feb 2020 10:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Usha P
usha.p@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment