Tommie Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 8:
(23 comments)
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... PS6, Line 5: ramstage-y += mainboard.c
Could we just put SAR function into variant. […]
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/variant.c:
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 41: const char *filename = NULL;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 41: const char *filename = NULL;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 42: uint32_t sku_id = get_board_sku();
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 42: uint32_t sku_id = get_board_sku();
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 44: if (sku_id == 9)
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 44: if (sku_id == 9)
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 45: filename = "wifi_sar-foob360.hex";
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 45: filename = "wifi_sar-foob360.hex";
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 46: return filename;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 46: return filename;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 51: static uint32_t sku_id = SKU_UNKNOWN;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 51: static uint32_t sku_id = SKU_UNKNOWN;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 53: if (sku_id != SKU_UNKNOWN)
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 53: if (sku_id != SKU_UNKNOWN)
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 54: return sku_id;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 54: return sku_id;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 56: if (google_chromeec_cbi_get_sku_id(&sku_id))
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 56: if (google_chromeec_cbi_get_sku_id(&sku_id))
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 57: sku_id = SKU_UNKNOWN;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 57: sku_id = SKU_UNKNOWN;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 59: return sku_id;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 59: return sku_id;
code indent should use tabs where possible
Done