Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41209 )
Change subject: fw_config: Add firmware configuration interface
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41209/5/src/lib/fw_config.c
File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/41209/5/src/lib/fw_config.c@67
PS5, Line 67: match->field_name && match->option_name
If the debug string aren't present, shouldn't we still match (but not print out as much in the probe […]
I could key off "mask=0" and make that an invalid probe instead of needing the pointers to be a list terminator.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e889c235a81545e2ec0e3a34dfa750ac828a330
Gerrit-Change-Number: 41209
Gerrit-PatchSet: 5
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
reinauer@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 18 May 2020 16:26:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jett Rink
jettrink@chromium.org
Gerrit-MessageType: comment