Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30891 )
Change subject: console: Change BOOTBLOCK_CONSOLE default to `y`
......................................................................
Patch Set 2:
There is no VERSTAGE_CONSOLE. For simplicity, I feel verstage could live without the knowledge of how to configure console from scratch. Specially usbdebug.
Ah, misunderstood you there. So basically, you want to drop the
hardware initialization part of console_init() in verstage_main()?
Then, only enable printk() if BOOTBLOCK_CONSOLE?
A related question; even with BOOTBLOCK_CONSOLE=n, should mainboard bootblock do LPC configuration?
I'd say yes. My current ports always initialize the path to the
UART and its resources in the bootblock; and don't repeat that
later. `git grep IS_ENABLED(CONFIG_BOOTBLOCK_CONSOLE)` doesn't
suggest anything else.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30891
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c5b671b7dddb5c6535c97c2cbb5f5053909dc64
Gerrit-Change-Number: 30891
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 13 Jan 2019 13:58:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment