build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36545 )
Change subject: lib/cbfs: Add fallback to RO region to cbfs_boot_locate
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36545/2/src/lib/cbfs.c
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/36545/2/src/lib/cbfs.c@71
PS2, Line 71: * This functionality is intended for very specific situations where flash space is a
line over 96 characters
https://review.coreboot.org/c/coreboot/+/36545/2/src/lib/cbfs.c@72
PS2, Line 72: * major concern. It should be used with care. It allows us to avoid duplicate files
line over 96 characters
https://review.coreboot.org/c/coreboot/+/36545/2/src/lib/cbfs.c@73
PS2, Line 73: * in the RO and RW partitions while still updateability in case this is required in a
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81ceaf927280cef9a3f09621c796c451e9115211
Gerrit-Change-Number: 36545
Gerrit-PatchSet: 2
Gerrit-Owner: Wim Vervoorn
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Wim Vervoorn
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Nov 2019 13:10:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment