Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33300 )
Change subject: [RFC and WIP]Add an option to align FMAP regions ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33300/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33300/1//COMMIT_MSG@15 PS1, Line 15: such configuration presents itself
so there are 3 options I see: […]
I think they should be mutually exclusive. That makes the syntax easiest and I don't think there's any use case for having both together. When you put an explicit offset, that should be the offset you get.
https://review.coreboot.org/#/c/33300/1//COMMIT_MSG@16 PS1, Line 16: - '~' is used. Is that the 'best' symbol
the flags are now places right after the SECTION name, so it looks like SECTION(<flags>)@base size ~ […]
Oh... no, sorry, that was just me misremembering the format, I don't think we need to change the flags format. But I think the alignment should be written in place of the explicit offset, wherever that is. So the new format should be
SECTION(CBFS)@0x10000 32K # for explicit offsets SECTION(CBFS)/4K 32K # for auto-placed with alignment