Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39839 )
Change subject: lp/drivers/usb: Add quirk for QEMU XHCI root hub ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/generic_hub.c:
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers... PS2, Line 222: hub_status_changed
Alternatively to the whole quirk infrastructure, could we just not […]
I actually looked at that first, it is a bit messy because the RH is added before the PCI device is hooked in, so at the time xhci_rh_init runs it doesn't know the PCI device. I was going to fix that init path as well but this seemed like it would need a quirk check at some level anyway...
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/quirks.c:
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers... PS2, Line 62: #if CONFIG(LP_USB_PCI)
Can we leave this to the linker?
Maybe? All the other PCI use is guarded in this directory so I went for consistency.