Attention is currently required from: Tim Wawrzynczak, EricR Lai. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57634 )
Change subject: mb/google/brya: Add WWAN power off sequence ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57634/comment/04b38faf_374ff873 PS2, Line 7: power off The noun should be spelled without a space: poweroff
https://review.coreboot.org/c/coreboot/+/57634/comment/832946b5_a95cf08d PS2, Line 12: meet meeting
File src/mainboard/google/brya/variants/brya0/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/57634/comment/e2abcdc4_d87aeef1 PS2, Line 11: T1_OFF Please add the unit to the variable name like `T1_OFF_MS`.