Attention is currently required from: Raul Rangel, Angel Pons, Nicholas Chin.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60025 )
Change subject: payloads/Makefile.inc: Add warning for image built with no payload
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File payloads/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/60025/comment/ca206a17_4bceed3d
PS3, Line 51: CONFIG_PAYLOAD_NONE
So all the ChromeOS builds have CONFIG_PAYLOAD_NONE. The payload gets added later. […]
Yes, but for ChromeOS you'll only see it if you are digging through portage logs ;)
for upstream, I don't mind it, I think it makes sense for end-users, developers should ostensibly know what they're doing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60025
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ae9548a45e9f566c84db41e8e171c6bc179057
Gerrit-Change-Number: 60025
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: AreYouLoco?
areyouloco@paranoici.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nicholas Chin
Gerrit-Comment-Date: Mon, 20 Dec 2021 16:33:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment
