build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38463 )
Change subject: src/mainboard/system76: Add System76 Lemur Pro (lemp9) ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/c/coreboot/+/38463/1/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38463/1/src/mainboard/system76/lemp... PS1, Line 20: void bootblock_mainboard_init(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/38463/1/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38463/1/src/mainboard/system76/lemp... PS1, Line 19: void mainboard_silicon_init_params(FSP_S_CONFIG *params) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/38463/1/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/romstage.c:
https://review.coreboot.org/c/coreboot/+/38463/1/src/mainboard/system76/lemp... PS1, Line 46: //{0x0F, 0x00}, {0xFF, 0x00}, {0xFF, 0x00} code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38463/1/src/mainboard/system76/lemp... PS1, Line 46: //{0x0F, 0x00}, {0xFF, 0x00}, {0xFF, 0x00} please, no space before tabs
https://review.coreboot.org/c/coreboot/+/38463/1/src/mainboard/system76/lemp... PS1, Line 50: //{0x33, 0x00}, {0xFF, 0x00}, {0xFF, 0x00} code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38463/1/src/mainboard/system76/lemp... PS1, Line 50: //{0x33, 0x00}, {0xFF, 0x00}, {0xFF, 0x00} please, no space before tabs
https://review.coreboot.org/c/coreboot/+/38463/1/src/mainboard/system76/lemp... PS1, Line 95: void mainboard_memory_init_params(FSPM_UPD *memupd) { open brace '{' following function definitions go on the next line