[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/ehl: Set Ethernet controller to D0 power state

[Martin Roth (Code Review)]

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67976 )

Change subject: soc/intel/ehl: Set Ethernet controller to D0 power state
......................................................................

soc/intel/ehl: Set Ethernet controller to D0 power state

To be able to change the MAC addresses, it is necessary that the
controllers are in D0 power state. As of FSP MR3, Intel has set the
controllers to D3 power state at the end of FSP-S TSN GbE
initialization. This patch sets the state back to D0 before the
programming of the MAC addresses.

Test:
- Build coreboot with FSP MR4 for mc_ehl2 mainboard
- Boot into Linux and check MAC addr via 'ip a'

Change-Id: I4002d58eb4332ba45c35d07820900dfd2c637f21
Signed-off-by: Mario Scheithauer 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67976
Tested-by: build bot (Jenkins) 
Reviewed-by: Werner Zeh 
Reviewed-by: Lean Sheng Tan 
---
M src/soc/intel/elkhartlake/tsn_gbe.c
1 file changed, 33 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Werner Zeh: Looks good to me, approved
  Lean Sheng Tan: Looks good to me, approved

diff --git a/src/soc/intel/elkhartlake/tsn_gbe.c b/src/soc/intel/elkhartlake/tsn_gbe.c
index ea2ef0e..49ce4da 100644
--- a/src/soc/intel/elkhartlake/tsn_gbe.c
+++ b/src/soc/intel/elkhartlake/tsn_gbe.c
@@ -3,6 +3,7 @@
 #include <console/console.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
+#include <intelblocks/lpss.h>
 #include <soc/soc_chip.h>
 #include <soc/tsn_gbe.h>
 #include <timer.h>
@@ -99,6 +100,13 @@
    }
 }

+static void gbe_tsn_enable(struct device *dev)
+{
+	/* Ensure controller is in D0 state. */
+	lpss_set_power_state(PCI_DEV(0, PCI_SLOT(dev->path.pci.devfn),
+			PCI_FUNC(dev->path.pci.devfn)), STATE_D0);
+}
+
 static void gbe_tsn_init(struct device *dev)
 {
    /* Get the base address of the I/O registers in memory space */
@@ -127,6 +135,7 @@
    .read_resources   = pci_dev_read_resources,
    .set_resources    = pci_dev_set_resources,
    .enable_resources = pci_dev_enable_resources,
+	.enable           = gbe_tsn_enable,
    .init             = gbe_tsn_init,
 };