[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/i945: Remove redundant use of ACPI offset operator

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins), Lijian Zhao,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31671

to look at the new patch set (#2).

Change subject: nb/intel/i945: Remove redundant use of ACPI offset operator
......................................................................

nb/intel/i945: Remove redundant use of ACPI offset operator

IASL detect Unnecessary/redundant uses of the Offset() operator within
a Field Unit list.
it then send a remark "^ Unnecessary/redundant use of Offset"

example:
    OperationRegion (OPR1, SystemMemory, 0x100, 0x100)
    Field (OPR1)
    {
        Offset (0),     // Never needed
        FLD1, 32,
        Offset (4),     // Redundant, offset is already 4 (bytes)
        FLD2, 8,
        Offset (64),    // OK use of Offset.
        FLD3, 16,
    }

We will have those remark:
dsdt.asl     14:         Offset (0),
Remark   2158 -                 ^ Unnecessary/redundant use of Offset
operator

dsdt.asl     16:         Offset (4),
Remark   2158 -                 ^ Unnecessary/redundant use of Offset
operator

Change-Id: Ie1f2a2ace335af7984209c9e286b9f85e5342a7e
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/i945/acpi/hostbridge.asl
1 file changed, 9 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/31671/2