Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38740 )
Change subject: mainboard/google/{hatch,fizz}: Fix gpio common code TODO
......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/38740/1/src/lib/gpio.c
File src/lib/gpio.c:
https://review.coreboot.org/c/coreboot/+/38740/1/src/lib/gpio.c@193
PS1, Line 193: return stopwatch_duration_msecs(&sw);
Equivalent:
long timeout = wait_us(timeout, gpio_get(gpio));
if (timeout)
return timeout;
return -1;
(Considering that just using wait_us() directly in the code is barely any longer, do we really need this function?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38740
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c67f04ae458a0e47f4bb022d744dd8b8a0789ee
Gerrit-Change-Number: 38740
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 08 Feb 2020 00:45:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment