Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney, Julius Werner.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47284 )
Change subject: sc7280: support bitbang UART w/gpio
......................................................................
Patch Set 34:
(2 comments)
Patchset:
PS30:
Please factor this out into common code. […]
No idea, why this was marked as resolved (by me?). Anyway, it should be common code.
File src/soc/qualcomm/sc7280/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47284/comment/1986c4da_69b21ddb
PS34, Line 14: ################################################################################
Why are you adding these two lines? Unrelated and looks inconsistent with the rest.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47284
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6c70f917a59e233f6ea518d9c39f73fe84991c3
Gerrit-Change-Number: 47284
Gerrit-PatchSet: 34
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 26 Apr 2021 04:30:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment
