[coreboot-gerrit] Change in coreboot[master]: soc/intel/*: simplify XdciEnable code

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43860 )

Change subject: soc/intel/*: simplify XdciEnable code
......................................................................

Patch Set 6:

I just tried to find a reason to fully support this, but couldn't.
The problem why I don't see the new version as better: It raises
alarms when reading the code (without its history in mind). For
instance, when I see `...(dev)...; if (dev)` I naturally stumble
(why did we use `dev` before the NULL check?).

IIRC, I argued against is_dev_enabled() as it is, but it was merged
before I had the time to review. It hides a NULL check which makes
simple use cases look nice, but complex code less readable.