[coreboot-gerrit] Change in coreboot[master]: mb/ocp/monolake: Add a GPIO table for initializing configuration

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35367 )

Change subject: mb/ocp/monolake: Add a GPIO table for initializing configuration
......................................................................

Patch Set 2: Code-Review-1

(1 comment)

Thanks for doing this, Jingle. I started reviewing some of the GPIOs and may have questions tomorrow :-)

https://review.coreboot.org/c/coreboot/+/35367/1/src/mainboard/ocp/monolake/... 
File src/mainboard/ocp/monolake/gpio.h:

https://review.coreboot.org/c/coreboot/+/35367/1/src/mainboard/ocp/monolake/... 
PS1, Line 21: static const struct gpio_config gpio_tables[] = {
Header files are generally only used for declarations. Since this is a definition it should go in a source file (e.g. romstage.c).