Thanks for doing this, Jingle. I started reviewing some of the GPIOs and may have questions tomorrow :-)

Patch set 2:Code-Review -1

View Change

1 comment:

• File src/mainboard/ocp/monolake/gpio.h:

  • Patch Set #1, Line 21: static const struct gpio_config gpio_tables[] = {

    Header files are generally only used for declarations. Since this is a definition it should go in a source file (e.g. romstage.c).

To view, visit change 35367. To unsubscribe, or for help writing mail filters, visit settings.