Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34662 )
Change subject: Documentation/binaries: Add AMD FSP documentation
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34662/11/Documentation/binaries/amd...
File Documentation/binaries/amd/AMD_FSP_family_17h.md:
https://review.coreboot.org/c/coreboot/+/34662/11/Documentation/binaries/amd...
PS11, Line 23: already enabled.
Can you refer to 'PSP directory' instead of 'header', if that is the case. I assume util/amdfwtool changes have already published those structures, so while Secure Processor specs may still be under NDA, it should not prevent from documenting this more accurately here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59a5d34df93cd0ff647e2ccfdbf8700b4df00a59
Gerrit-Change-Number: 34662
Gerrit-PatchSet: 11
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kerry Brown
kerry.brown@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 26 Aug 2019 22:43:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment