Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46407 )
Change subject: soc/mediatek/mt8192: Enable DCM
......................................................................
Patch Set 41:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46407/41/src/soc/mediatek/mt8192/pl...
File src/soc/mediatek/mt8192/pll.c:
https://review.coreboot.org/c/coreboot/+/46407/41/src/soc/mediatek/mt8192/pl...
PS41, Line 431: clrsetbits_le32
Since mt8192 is little endian, I think it's the same as clrsetbits32. Please double check.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46407
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5528d176b6bb1f9a5960de981766235510e6ebf1
Gerrit-Change-Number: 46407
Gerrit-PatchSet: 41
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Assignee: Michael Kao
michael.kao@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Kao
michael.kao@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 14 Dec 2020 08:13:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment