[coreboot-gerrit] Change in ...coreboot[master]: soc/amd/common: Create AcpiMmio functionality from stoneyridge

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32649 )

Change subject: soc/amd/common: Create AcpiMmio functionality from stoneyridge
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32649/4/src/soc/amd/common/block/include/amd... 
File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:

https://review.coreboot.org/#/c/32649/4/src/soc/amd/common/block/include/amd... 
PS4, Line 45: 0xfed80000
> ...are you using a recent iasl to test that?  I know that older iasl versions had issues with it,

Looks like it reports 20190108, which in infer is ~5 weeks behind our 20190215.  I can try again with that if you think it changed within that timeframe.  My preference is to use more of the defines in ASL code, but I kept running into frustrations like that.