build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46402 )
Change subject: soc/mediatek/mt8192: devapc: add basic dapc drivers ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46402/7/src/soc/mediatek/mt8192/dev... File src/soc/mediatek/mt8192/devapc.c:
https://review.coreboot.org/c/coreboot/+/46402/7/src/soc/mediatek/mt8192/dev... PS7, Line 14: write32((void*)MAS_SEC, val); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/46402/7/src/soc/mediatek/mt8192/dev... PS7, Line 16: if (read32((const void*)MAS_SEC) != val) "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/46402/7/src/soc/mediatek/mt8192/dev... PS7, Line 25: write32((void*)AO_APC_CON, 0x1); "(foo*)" should be "(foo *)"