Attention is currently required from: Tim Wawrzynczak, John Zhao, Rajmohan Mani.
Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48630 )
Change subject: drivers/intel/usb4: Enable retimer FW upgrade mux interaction
......................................................................
Patch Set 8:
(2 comments)
File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/48630/comment/9044e48b_1442180a
PS7, Line 33: 07
This needs to be changed to 1f, as 2 more functions are supported on top the first 3 (which is indic […]
Done
https://review.coreboot.org/c/coreboot/+/48630/comment/1664cfa8_3bfe8514
PS7, Line 111: // Get argument for on/off from Arg3[0]
This needs to be changed, as we set new retimer mux info here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48630
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I768cfb56790049c231173b0ea0f8e08fe6b64b93
Gerrit-Change-Number: 48630
Gerrit-PatchSet: 8
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Comment-Date: Thu, 07 Jan 2021 23:25:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-MessageType: comment