21 Jan
2021
21 Jan
'21
12:56 p.m.
Attention is currently required from: Nico Huber, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48236 )
Change subject: mb/emulation/qemu-q35: Account for TSEG ......................................................................
Patch Set 10:
(2 comments)
File src/mainboard/emulation/qemu-q35/memmap.c:
https://review.coreboot.org/c/coreboot/+/48236/comment/7abbb257_c22134f4 PS8, Line 25: esmramc
Should we check the enable bit? […]
Ack
https://review.coreboot.org/c/coreboot/+/48236/comment/bf7527e5_b40bf82f PS8, Line 42: 0x%08lx
%p ? […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/48236
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fd82a42d6602f1369bb3c69556c46f537542705
Gerrit-Change-Number: 48236
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 21 Jan 2021 12:56:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment