Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44741 )
Change subject: soc/intel/cnl: Allow enabling/disabling PEG devices ......................................................................
Patch Set 13: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44741/13/src/soc/intel/cannonlake/i... File src/soc/intel/cannonlake/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/44741/13/src/soc/intel/cannonlake/i... PS13, Line 26: #define SA_DEVFN_PEG0 PCI_DEVFN(SA_DEV_SLOT_PEG, 0) On other platforms with a PEG device on PCI_DEV(0, 6, 0) we needed to define each device. But here?
#define SA_DEVFN_PEG(x) PCI_DEVFN(SA_DEV_SLOT_PEG, x) #define SA_DEV_PEG(x) PCI_DEV(0, SA_DEV_SLOT_PEG, x)
This allows using the macros to iterate over all PEG functions 😜