Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47972 )
Change subject: mb/google/volteer: Make use of fw_config_is_provisioned() ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47972/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/fw_config.c:
https://review.coreboot.org/c/coreboot/+/47972/2/src/mainboard/google/voltee... PS2, Line 74: {
nit: If you handle the unprovisioned case first, then you don't need to align the rest of the code b […]
Done
https://review.coreboot.org/c/coreboot/+/47972/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/romstage.c:
https://review.coreboot.org/c/coreboot/+/47972/2/src/mainboard/google/voltee... PS2, Line 27: mem_cfg->PchHdaEnable = 0;
Not for this change, but I think, we should update baseboard/devicetree.cb so that […]
Agreed
https://review.coreboot.org/c/coreboot/+/47972/2/src/mainboard/google/voltee... PS2, Line 35: mem_cfg->TcssDma0En = 0; : mem_cfg->TcssItbtPcie0En = 0; : mem_cfg->TcssItbtPcie1En = 0;
I think we already have devices in devicetree that correspond to each of these UPDs. […]
Looks redundant, cleaned up in followup.