6 Oct
2020
6 Oct
'20
10:17 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45811 )
Change subject: mb/google/kukui: Support SKU from camera EEPROM ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45811/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/45811/2/src/mainboard/google/kukui/... PS2, Line 142: check_cros_camera_info
When CONFIG(BOARD_GOOGLE_KODAMA), shouldn't CONFIG(CHROMEOS) also be 1? I can run […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/45811
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63a2b952b8c35c0ead8200d7c926e8d90a9f3fb8
Gerrit-Change-Number: 45811
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Oct 2020 07:17:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Gerrit-MessageType: comment