[coreboot-gerrit] Change in coreboot[master]: {drivers,soc}/intel/fsp2_0: Move chipset specific logo handling to SoC

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37792 )

Change subject: {drivers,soc}/intel/fsp2_0: Move chipset specific logo handling to SoC
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37792/7/src/drivers/intel/fsp2_0/lo... 
File src/drivers/intel/fsp2_0/logo.c:

https://review.coreboot.org/c/coreboot/+/37792/7/src/drivers/intel/fsp2_0/lo... 
PS7, Line 34: }
> This looks much like the function in fsp1_1/, aren't they identical? […]

You are right that the code is exactly the same and the only difference is in the includes. Still I don't think it is a good idea to move this to lib as this functionality is only relevant for the fsp implementations. It is not generic code. Also I don't expect the FSP 1.1 code to be around forever and once that goes away the fsp 2 code is the only location.