Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31144 )
Change subject: nb/intel/i945: Correct mask for CxDRT1 ......................................................................
Patch Set 2: Code-Review-1
(2 comments)
https://review.coreboot.org/#/c/31144/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31144/2//COMMIT_MSG@9 PS2, Line 9: [27:24] and [31:30] are reserved The code explicitly sets bits [31:30]. The one who wrote this code had better documentation than the publicly available one.
https://review.coreboot.org/#/c/31144/2//COMMIT_MSG@10 PS2, Line 10: Tested on i945G-M4 board. What does it do better with this change?