Attention is currently required from: Hung-Te Lin, Wentao Qin, Xuxin Xiong, Yang Wu, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82089?usp=email )
Change subject: mb/google/corsola/wugtrio: Add initialization of USB port0
......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82089/comment/60c25952_6f873dd8 :
PS9, Line 7: port0
I’d spell it with a space: port 0
(If you agree, please update all other places too.)
https://review.coreboot.org/c/coreboot/+/82089/comment/344039e1_7154c259 :
PS9, Line 7: Add initialization of
Initialize
https://review.coreboot.org/c/coreboot/+/82089/comment/73e7b445_7c4ce28f :
PS9, Line 11:
Please describe the implementation. You use fwconfig for this, for example?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82089?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I725b80593f5fc498a204bf47f943c36ccbd78134
Gerrit-Change-Number: 82089
Gerrit-PatchSet: 9
Gerrit-Owner: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Mingjin Ge
mingjin.ge@mediatek.corp-partner.google.com
Gerrit-Reviewer: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 29 Apr 2024 08:46:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment