Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41334 )
Change subject: soc/intel/common: Improve Type16 SMBIOS tables ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/41334/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41334/1//COMMIT_MSG@7 PS1, Line 7: Better
Use a verb: Improve …
Done
https://review.coreboot.org/c/coreboot/+/41334/1//COMMIT_MSG@14 PS1, Line 14: * Assume the same bits for Tiger Lake as for Ice Lake
Default is 64 GB here?
yes
https://review.coreboot.org/c/coreboot/+/41334/1//COMMIT_MSG@15 PS1, Line 15: CoffeeLake
Coffee Lake
Done
https://review.coreboot.org/c/coreboot/+/41334/1//COMMIT_MSG@15 PS1, Line 15: SkyLake
Skylake
Done
https://review.coreboot.org/c/coreboot/+/41334/1/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/systemagent.h:
https://review.coreboot.org/c/coreboot/+/41334/1/src/soc/intel/common/block/... PS1, Line 96: uint32_t soc_systemagent_max_chan_capacity(u8 capid0_a_ddrsz);
Add _mib to the function name?
Done