Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44915 )
Change subject: drivers/intel/usb4: Add driver for USB4 PCIe root port ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... File src/drivers/intel/usb4/pcie/Kconfig:
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... PS2, Line 2: bool depends on HAVE_ACPI_TABLES?
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... File src/drivers/intel/usb4/pcie/chip.h:
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... PS2, Line 9: USB port number Is this the port number as assigned in hardware? Or is this just a unique number assigned for each port under a particular controller?
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... File src/drivers/intel/usb4/pcie/pcie.c:
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... PS2, Line 17: dev->chip_info; config_of(dev)
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... PS2, Line 17: struct const
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... PS2, Line 23: if (!config->usb4_port) Should there be an error printed in case usb4_port device is not found?
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... PS2, Line 29: return; Print error in this case?