Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35163 )
Change subject: mb/supermicro: Add X10SLM+-LN4F as X10SLM variant
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35163/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35163/5//COMMIT_MSG@14
PS5, Line 14:
what about cb/Documentation/mb/x10...?
https://review.coreboot.org/c/coreboot/+/35163/5/src/mainboard/supermicro/x1...
File src/mainboard/supermicro/x10slm/Kconfig:
https://review.coreboot.org/c/coreboot/+/35163/5/src/mainboard/supermicro/x1...
PS5, Line 18: if BOARD_SUPERMICRO_X10SLM_PLUS_F || BOARD_SUPERMICRO_X10SLM_PLUS_LN4F
this will get very long when more boards get added. use the x11 series as reference
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35163
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I686d8d4e2ec5b4eb2db214b6e0827ac9c33829d1
Gerrit-Change-Number: 35163
Gerrit-PatchSet: 5
Gerrit-Owner: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Oct 2019 21:57:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment