Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mb/clevo/n141cu: Add new Comet Lake mainboard ......................................................................
Patch Set 36:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40581/36/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/40581/36/src/mainboard/clevo/cml-u/... PS36, Line 78:
TPM_PIRQ probably missing
config TPM_PIRQ hex default 0x10 # GPP_A7/PIRQA#
https://review.coreboot.org/c/coreboot/+/40581/36/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/variants/n141cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40581/36/src/mainboard/clevo/cml-u/... PS36, Line 145: register "serirq_mode" = "SERIRQ_CONTINUOUS" I suspect the ec is the only serirq user, just like on N150CU; check that in the schematics; if that is true, this can be dropped or set to SERIRQ_QUIET to save power
https://review.coreboot.org/c/coreboot/+/40581/36/src/mainboard/clevo/cml-u/... PS36, Line 146: chip drivers/pc80/tpm : device pnp 0c31.0 on end : end : move to 1f.5