Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34857 )
Change subject: mb/ocp/monolake: Add IPMI CMOS clear support
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
Patch Set 3:
I don't see why that should be board specific.
This is implemented according to Mono Lake specific OEM command spec but not standard IPMI spec, therefore I think it's board specific.
On the first sight it looked like "Set System Boot Options" and "Get System Boot Options" from the Chassis Netfn. Can you reference the OEM spec you are using to implement that functionality?
The OEM spec is confidential and cannot be found in the public, so I am afraid that I'm not able to reference it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21d44557896680cfac3c3b6d83e07b755b242cad
Gerrit-Change-Number: 34857
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: David Hendricks
dhendrix.sync@gmail.com
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: Łukasz Siudut
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Aug 2019 05:45:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment