Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45822 )
Change subject: lib/ubsan.c: Remove GCC 5.x workaround ......................................................................
lib/ubsan.c: Remove GCC 5.x workaround
The coreboot toolchain has been using a newer GCC version for a while already. This code is build-tested from commit 13cd145e02e onwards.
Change-Id: Ic324b503878c73e4560d4d8f2e0d38ecb595b8fd Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/lib/ubsan.c 1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/45822/1
diff --git a/src/lib/ubsan.c b/src/lib/ubsan.c index 6873f7e..1037b1b 100644 --- a/src/lib/ubsan.c +++ b/src/lib/ubsan.c @@ -245,15 +245,7 @@ ABORT_VARIANT_VP_VP(vla_bound_not_positive);
struct ubsan_float_cast_overflow_data { -/* -* TODO: Remove this GCC 5.x compatibility after switching to GCC 6.x. The -* GCC developers accidentally forgot the source location. Their -* libubsan probes to see if it looks like a path, but we don't need -* to maintain compatibility with multiple gcc releases. See below. -*/ -#if !(defined(__GNUC__) && __GNUC__ < 6) struct ubsan_source_location location; -#endif struct ubsan_type_descriptor *from_type; struct ubsan_type_descriptor *to_type; }; @@ -264,11 +256,7 @@ (struct ubsan_float_cast_overflow_data *)data_raw; ubsan_value_handle_t from = (ubsan_value_handle_t)from_raw; (void) from; -#if !(defined(__GNUC__) && __GNUC__ < 6) ubsan_abort(&data->location, "float cast overflow"); -#else - ubsan_abort(((void) data, &unknown_location), "float cast overflow"); -#endif }
ABORT_VARIANT_VP_VP(float_cast_overflow);