Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47017 )
Change subject: soc/intel/common: Create common Intel FSP reset code block
......................................................................
Patch Set 3:
(2 comments)
Patch Set 2: Code-Review+1
(2 comments)
This approach looks much better. Thanks!
Thanks Angel for your suggestion
https://review.coreboot.org/c/coreboot/+/47017/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47017/2//COMMIT_MSG@9
PS2, Line 9: to
Please wrap at 72 characters
Ack
https://review.coreboot.org/c/coreboot/+/47017/2/src/drivers/intel/fsp2_0/Kc...
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/47017/2/src/drivers/intel/fsp2_0/Kc...
PS2, Line 229: FSP_STATUS_GLOBAL_RESET
depends on SOC_INTEL_COMMON_FSP_RESET
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47017
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I934b41affed7bb146f53ff6a4654fdbc6626101b
Gerrit-Change-Number: 47017
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Sat, 31 Oct 2020 16:27:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment