Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42455 )
Change subject: nb/intel/sandybridge/gma.c: Correct deasserting force wake on IVB ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42455/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42455/1//COMMIT_MSG@8 PS1, Line 8: Maybe add the reason I commented on CB:42410 here?
Reference code does two separate writes. We shall follow suit.
https://review.coreboot.org/c/coreboot/+/42455/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/gma.c:
https://review.coreboot.org/c/coreboot/+/42455/1/src/northbridge/intel/sandy... PS1, Line 513: 0x1ffff For consistency, use: ~0xfffe0000