Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38517 )
Change subject: mb/intel/jasperlake_rvp: Add proper Kconfig for chrome ec support ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38517/3/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/38517/3/src/mainboard/intel/jasperl... PS3, Line 37: select EC_GOOGLE_CHROMEEC : select EC_GOOGLE_CHROMEEC_LPC : select EC_GOOGLE_CHROMEEC_SWITCHES We can select these configs under BOARD_INTEL_JASPERLAKE_RVP_EXT_EC in Kconfig.name. So we don't need this config item. Same for JSL_INTEL_EC and JSL_HAS_TPM.
https://review.coreboot.org/c/coreboot/+/38517/3/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/38517/3/src/mainboard/intel/jasperl... PS3, Line 46: #endif Add a comment after endif /* !CONFIG(EC_GOOGLE_CHROMEEC_SWITCHES) */