Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42339 )
Change subject: soc/amd/picasso: Include uart.c unconditionally ......................................................................
Patch Set 1: Code-Review-1
already tried this quick-fix and it doesn't unbreak Mandolin; it just breaks it in a different way:
/home/felix/coreboot/util/crossgcc/xgcc/bin/i386-elf-ld.bfd: build/bootblock/soc/amd/picasso/uart.o: in function `uart_platform_base': /home/felix/coreboot/src/soc/amd/picasso/uart.c:34: multiple definition of `uart_platform_base'; build/bootblock/drivers/uart/uart8250io.o:/home/felix/coreboot/src/drivers/uart/uart8250io.c:81: first defined here /home/felix/coreboot/util/crossgcc/xgcc/bin/i386-elf-ld.bfd: build/bootblock/soc/amd/picasso/uart.o: in function `uart_platform_refclk': /home/felix/coreboot/src/soc/amd/picasso/uart.c:76: multiple definition of `uart_platform_refclk'; build/bootblock/drivers/uart/util.o:/home/felix/coreboot/src/drivers/uart/util.c:44: first defined here src/arch/x86/Makefile.inc:117: recipe for target 'build/cbfs/fallback/bootblock.debug' failed