Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37719 )
Change subject: biostar/am1ml: Switch away from ROMCC_BOOTBLOCK
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37719/2/src/mainboard/biostar/am1ml...
File src/mainboard/biostar/am1ml/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37719/2/src/mainboard/biostar/am1ml...
PS2, Line 102: ite_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
You lost ite_kill_watchdog() now completely?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37719
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a972b531183b08af7b325bd686cf3eb7558082f
Gerrit-Change-Number: 37719
Gerrit-PatchSet: 5
Gerrit-Owner: Sergej Ivanov
getinaks@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sergej Ivanov
getinaks@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 16 Dec 2019 12:55:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment