Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45738 )
Change subject: soc/intel: Fix GRXS function to get GPIO number proper
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45738/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45738/1//COMMIT_MSG@9
PS1, Line 9: This patch ensures that GRXS perform PAD_CFG0_RX_STATE
: mask first and then right shift PAD_CFG0_RX_STATE_BIT to
: get correct GPIO number.
72 chars wide
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45738
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96611936f70f79e9dc5ee9414ec68cef00d0d13a
Gerrit-Change-Number: 45738
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 25 Sep 2020 15:54:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment