Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33985 )
Change subject: include/cpu/x86: Add STM Support ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/33985/4/src/include/cpu/x86/smm.h File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/33985/4/src/include/cpu/x86/smm.h@6... PS4, Line 67: useg "used"? But I'd just say "Monitor Segment, when using STM" to explain what mseg is. That it's kept here for setup can be easily derived from the code.
https://review.coreboot.org/c/coreboot/+/33985/4/src/include/cpu/x86/smm.h@6... PS4, Line 69: /* used so that the STM can start the SMI handler in 32bit mode */ would rephrase as "STM's 32bit mode entry point into SMI handler" or something like that.