Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42280 )
Change subject: mb/ocp/deltalake: Implement SMBIOS type 9 by SKU ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42280/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42280/2//COMMIT_MSG@7 PS2, Line 7: mb/ocp/deltalake: Implement SMBIOS type 9 by SKU Implement SMBIOS type 9 -- system slots
https://review.coreboot.org/c/coreboot/+/42280/2//COMMIT_MSG@11 PS2, Line 11: TEST=Check SMBIOS type 9 is created correctly by different SKUs "by different SKUs" --> "on different SKUs"
https://review.coreboot.org/c/coreboot/+/42280/2/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/42280/2/src/mainboard/ocp/deltalake... PS2, Line 29: #define STACK_BUSB2 0x4 Instead of using STACK_BUS<num>, let's use IIO_STACKS defined in hob_iiouds.h