Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45079 )
Change subject: soc/intel/elkhartlake: Add FSP-T support
......................................................................
Patch Set 3: Code-Review-1
Patch Set 3:
Patch Set 3:
Do we really need to rely on FSP-T?
In the past we often had this discussion and IIRC the coreboot native code for CAR bring up was always favored. Is there a way you can use the coreboot native code? Jasper Lake seems to be able and Elkhart Lake is based on Jasper Lake code.
Hi Werner, due to FSP-T is part of feature requirements so it is set as default and this setting has been tested extensively from our side. Let me add the native CAR later on as our testing parameters before i make sure this can be safely enabled on EHL 😊
Are you fine with this?
Please elaborate those "feature requirements".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45079
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d7f14e4e8be8755e01d9a3988608d5d47145496
Gerrit-Change-Number: 45079
Gerrit-PatchSet: 3
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 13 Sep 2020 10:54:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment