Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45229 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssh-f board as a variant ......................................................................
Patch Set 6:
(7 comments)
https://review.coreboot.org/c/coreboot/+/45229/6/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-f.md:
https://review.coreboot.org/c/coreboot/+/45229/6/Documentation/mainboard/sup... PS6, Line 21: If an IGD is integrated with CPU, it will be enabled on this board. Though there is no video output add a newline above
https://review.coreboot.org/c/coreboot/+/45229/6/Documentation/mainboard/sup... PS6, Line 22: it is said capable to be it is said to be capable of being used for
https://review.coreboot.org/c/coreboot/+/45229/6/Documentation/mainboard/sup... PS6, Line 23: render graphics for BMC huh? what for?
https://review.coreboot.org/c/coreboot/+/45229/6/Documentation/mainboard/sup... PS6, Line 23: switcheroo add a link?
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... PS3, Line 8:
inteltool dunp: https://pastebin. […]
great, thanks! I'll check that in the next days
https://review.coreboot.org/c/coreboot/+/45229/5/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45229/5/src/mainboard/supermicro/x1... PS5, Line 15: # This board has an IGD with no output. : register "PrimaryDisplay" = "Display_PCH_PCIe"
That was my fault, sorry. Let's keep auto see https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/45229/6/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45229/6/src/mainboard/supermicro/x1... PS6, Line 82: smbios_slot_desc "SlotTypePciExpressGen3X4" "SlotLengthLong" : smbios_slot_desc "PCH SLOT4 PCI-E 3.0 X4(IN X8)" "SlotDataBusWidth4X" : uhm, that won't work ;)