Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33737 )
Change subject: device/oprom: Add vbe return status support as per VBE spec 3.0
......................................................................
Patch Set 8:
Sorry for the late review, I've little time at the moment. And this
code for legacy concepts and binary blobs is really not what I like
to work on. If you would write modern open-source code for your
graphics cards instead, you would have my full attention :D
It took me some time to figure out that the code you edit in the two
commits ahead (yabel) and this (realmode) code are mutually exclusive.
You are going through a lot of trouble to make the existing `vbe_info_t`
compatible to your new code here. It would be much easier to declare
a new struct. Or instead of squeezing the yabel code into a new shape,
you could make its vbe_info code (vbe_info() and vbe_get_info()) common
to both implementations. The existing yabel code looks more comprehen-
sive than the mode listing here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iacd2ce468e038a14424f029df3a0adec3e5fa15c
Gerrit-Change-Number: 33737
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 07 Jul 2019 12:44:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment