[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Enable RTC support

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )

Change subject: soc/intel/cannonlake: Enable RTC support
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/31102/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31102/2//COMMIT_MSG@13 
PS2, Line 13: unavailable" error message gone.
> I don't see how this is related. Are you sure the message is fixed […]

Yes, you can check drivers/elog/elog.c, without CONFIG_RTC event log can't get current time and date.

https://review.coreboot.org/#/c/31102/2/src/soc/intel/cannonlake/Kconfig 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/#/c/31102/2/src/soc/intel/cannonlake/Kconfig@66 
PS2, Line 66: 	select SOC_INTEL_COMMON_BLOCK_RTC
> Already selected by SOC_INTEL_COMMON_PCH_BASE.

Good catch, yes I believe just line#52 is enough.