Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36600 )
Change subject: *.asl: Don't define devices by absolute path
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36600/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36600/3//COMMIT_MSG@11
PS3, Line 11: avoids '^' symbols
How so? I'm confused... It doesn't seem to change anything.
Agreed. I prefer reeducing the number of indentations on dsdt.asl
https://review.coreboot.org/c/coreboot/+/36600/3/src/mainboard/lenovo/t440p/...
File src/mainboard/lenovo/t440p/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36600/3/src/mainboard/lenovo/t440p/...
PS3, Line 40: Scope (_SB)
: {
: Device (PCI0)
: {
Scope (_SB) { […]
I have been advocating for _SB.PCI0 for a long while.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36600
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b8dd33fac7cb1524d920b77e95c08b839157e8f
Gerrit-Change-Number: 36600
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 01 Mar 2020 01:04:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment