Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/44795 )
Change subject: gma baytrail: Add PLL initialisation code
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/44795/9/common/valleyview/hw-gfx-...
File common/valleyview/hw-gfx-gma-plls.adb:
https://review.coreboot.org/c/libgfxinit/+/44795/9/common/valleyview/hw-gfx-...
PS9, Line 452: for P in DPLLs loop
AIUI, this is not going to work because you can't cross streams. Unless […]
I think there's something regarding which pipe goes to which port in one of the DPIO sequences (the only one that takes both a pipe and a port)
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/44795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I3f59e1cd6623f6c65cd1f8e231ea1aa1ec41bd16
Gerrit-Change-Number: 44795
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 06 Sep 2020 17:31:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment