Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45799 )
Change subject: mb/ocp/deltalake: Override smbios_fill_dimm_locator for type 17 ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/45799/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45799/5//COMMIT_MSG@10 PS5, Line 10: Also remove CONFIG(GENERATE_SMBIOS_TABLES) compile option because SMBIOS : is always enabled and it makes the code cleaner. Another approach is to move all SMBIOS stuff into a `smbios.c` file 😊
https://review.coreboot.org/c/coreboot/+/45799/5/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/45799/5/src/mainboard/ocp/deltalake... PS5, Line 246: dimm_locator[dimm->channel_num] I would just do:
'A' + dimm->channel_num